Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception when IAM Identity Center auth is used #629

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Improve exception when IAM Identity Center auth is used #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9bc5ee
Improve exception when IAM Identity Center auth is used
omus Jun 5, 2023
7d2fe95
Formatting
omus Jun 5, 2023
ee6dff5
Set project version to 1.87.1
omus Jun 7, 2023
0fdb08f
Merge branch 'master' into cv/iam-identity-center-auth-unsupported
omus Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "AWS"
uuid = "fbe9abb3-538b-5e4e-ba9e-bc94f4f92ebc"
license = "MIT"
version = "1.87.0"
version = "1.87.1"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down
11 changes: 11 additions & 0 deletions src/AWSCredentials.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,17 @@ function sso_credentials(profile=nothing)
settings = _aws_profile_config(ini, p)
isempty(settings) && return nothing

# AWS IAM Identity Center authentication is not yet supported in AWS.jl
sso_session = get(settings, "sso_session", nothing)
if !isnothing(sso_session)
error(
"IAM Identity Center authentication is not yet supported by AWS.jl. " *
"See https://github.com/JuliaCloud/AWS.jl/issues/628",
)
end

# Legacy SSO configuration
# https://docs.aws.amazon.com/cli/latest/userguide/sso-configure-profile-legacy.html#sso-configure-profile-manual
sso_start_url = get(settings, "sso_start_url", nothing)

if !isnothing(sso_start_url)
Expand Down
23 changes: 23 additions & 0 deletions test/AWSCredentials.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,29 @@ end
end
end

# TODO: Additional, precedence tests should be added for IAM Identity Center
# once support has been introduced.
@testset "IAM Identity Center preferred over legacy SSO" begin
write(
config_file,
"""
[sso-session my-sso]
sso_region = us-east-1
sso_start_url = https://my-sso-portal.awsapps.com/start

[default]
sso_session = my-sso
sso_start_url = https://my-legacy-sso-portal.awsapps.com/start
sso_role_name = role1
""",
)
isfile(creds_file) && rm(creds_file)

apply(Patches.sso_service_patches("AKI_SSO", "SAK_SSO")) do
@test_throws ErrorException AWSCredentials()
end
end

@testset "SSO preferred over credentials file" begin
write(
config_file,
Expand Down