Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception when IAM Identity Center auth is used #629

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Improve exception when IAM Identity Center auth is used #629

merged 4 commits into from
Jun 7, 2023

Conversation

omus
Copy link
Member

@omus omus commented Jun 5, 2023

AWS.jl currently doesn't support authentication via IAM Identity Center (successor to AWS SSO) (#628) which results in a NoCredentials exception being raised which is misleading. This PR simply throws a more helpful exception when users attempt to use this currently unsupported authentication method.

github-actions[bot]
github-actions bot reviewed Jun 5, 2023
View reviewed changes
src/AWSCredentials.jl Outdated Show resolved Hide resolved
@omus @github-actions
Formatting
7d2fe95 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@omus
Copy link
Member Author

omus commented Jun 6, 2023

bors try

bors bot added a commit that referenced this pull request Jun 6, 2023
@bors
Try #629:
043809d
@omus omus self-assigned this Jun 6, 2023
@bors
Copy link
Contributor

bors bot commented Jun 6, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@omus
Copy link
Member Author

omus commented Jun 7, 2023

bors try

@omus omus requested a review from mattBrzezinski June 7, 2023 17:51
bors bot added a commit that referenced this pull request Jun 7, 2023
@bors
Try #629:
f01598f
@bors
Copy link
Contributor

bors bot commented Jun 7, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@omus
Copy link
Member Author

omus commented Jun 7, 2023

bors try

bors bot added a commit that referenced this pull request Jun 7, 2023
@bors
Try #629:
fb10262
@bors
Copy link
Contributor

bors bot commented Jun 7, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@omus omus merged commit 7b09eb1 into master Jun 7, 2023
@omus omus deleted the cv/iam-identity-center-auth-unsupported branch June 7, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

Assignees

@omus omus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omus @mattBrzezinski