Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_065: ZM CCPP'ization round 4 (completes CCPP conversion of ZM) #1218

Merged
merged 23 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
812d476
Remove unused variables
cacraigucar May 17, 2024
600b8b6
Remove DIFZM as it is not used
cacraigucar May 22, 2024
61fa56c
Remove DIFZM output
cacraigucar May 23, 2024
4a5cdb5
Move limcnv calculation into ZM layer
cacraigucar May 29, 2024
2713176
Add constituent hooks for ccpp compatability
cacraigucar Jun 18, 2024
3504c51
Remove the 'use' statements
cacraigucar Jul 19, 2024
a6b5db5
Bug fixes to get cleanup3 to run in CAM
cacraigucar Aug 2, 2024
1e78173
Fixes after the atmos_phys merge
cacraigucar Aug 5, 2024
d0bc1a9
Remove zm_org logic per Rich Neale's advice
cacraigucar Aug 23, 2024
49bfd2a
Updated calling lists for zm routines
cacraigucar Sep 19, 2024
5e2d45a
Merge tag 'cam6_4_047' into cam_zm_cleanup4
cacraigucar Dec 16, 2024
0fdf1cc
Add diagnostic messages
cacraigucar Dec 18, 2024
0623736
Eliminate final whitespace which snuck in file
cacraigucar Jan 3, 2025
6f63133
Address reviewer comments
cacraigucar Jan 6, 2025
e900c71
Use Fotran unit handling
cacraigucar Jan 22, 2025
9947b25
Merge remote-tracking branch 'refs/remotes/origin/cam_zm_cleanup4' in…
cacraigucar Jan 22, 2025
fe947be
Merge tag 'cam6_4_056' into cam_zm_cleanup4
cacraigucar Jan 24, 2025
1180831
Update atmos_phys tag
cacraigucar Jan 29, 2025
85b14f3
remove unnecessary directory for configure to use
cacraigucar Feb 10, 2025
3ab5a5d
Address reviewer comments
cacraigucar Feb 10, 2025
94072d1
Update comments
cacraigucar Feb 10, 2025
1034b26
Merge tag 'cam6_4_064' into cam_zm_cleanup4
cacraigucar Feb 10, 2025
79aee2f
Updated ChangeLog for cam6_4_065
cacraigucar Feb 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
[submodule "atmos_phys"]
path = src/atmos_phys
url = https://github.com/ESCOMP/atmospheric_physics
fxtag = atmos_phys0_07_001
fxtag = atmos_phys0_08_000
fxrequired = AlwaysRequired
fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics

Expand Down
1 change: 0 additions & 1 deletion bld/build-namelist
Original file line number Diff line number Diff line change
Expand Up @@ -3660,7 +3660,6 @@ if (!$simple_phys) {
add_default($nl, 'zmconv_c0_ocn');
add_default($nl, 'zmconv_ke');
add_default($nl, 'zmconv_ke_lnd');
add_default($nl, 'zmconv_org');
add_default($nl, 'zmconv_num_cin');
add_default($nl, 'zmconv_dmpdz');
add_default($nl, 'zmconv_tiedke_add');
Expand Down
4 changes: 0 additions & 4 deletions bld/config_files/definition.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ Switch to turn on UNICON package: 0 => off, 1 => on
<entry id="clubb_do_adv" valid_values="0,1" value="0">
Switch to turn on/off advecting CLUBB moments: 0 => no, 1 => yes
</entry>
<entry id="zmconv_org" valid_values="0,1" value="0">
Switch to turn on/off parameterization for sub-grid scale convective organization for the ZM deep convective scheme based
on Mapes and Neale (2011): 0 => no, 1 => yes
</entry>
<entry id="pbl" valid_values="uw,hb,hbr,clubb_sgs,spcam_sam1mom,spcam_m2005,none" value="">
PBL package: uw (University of Washington), hb (Holtslag and Boville), hbr
(Holtslag, Boville, and Rasch), clubb_sgs, spcam_sam1om, spcam_m2005, none.
Expand Down
20 changes: 2 additions & 18 deletions bld/configure
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ OPTIONS
The user does not need to set this if one of the waccm chemistry options
is chosen.
-waccmx Build CAM/WACCM with WACCM upper Thermosphere/Ionosphere extended package
-zmconv_org Include parameterization for sub-grid scale convective organization for the ZM deep convective scheme based
on Mapes and Neale (2011)


Options relevent to SCAM mode:
Expand Down Expand Up @@ -317,7 +315,6 @@ GetOptions(
"version" => \$opts{'version'},
"waccm_phys" => \$opts{'waccm_phys'},
"waccmx" => \$opts{'waccmx'},
"zmconv_org" => \$opts{'zmconv_org'},
) or usage();

# Give usage message.
Expand Down Expand Up @@ -939,16 +936,6 @@ if (defined $opts{'clubb_opts'}) {
my $clubb_do_adv = $cfg_ref->get('clubb_do_adv');
if ($print>=2) { print "clubb_do_adv: $clubb_do_adv$eol"; }

#-----------------------------------------------------------------------------------------------
# ZM convective organization

if (defined $opts{'zmconv_org'}) {
$cfg_ref->set('zmconv_org', $opts{'zmconv_org'});
}

my $zmconv_org = $cfg_ref->get('zmconv_org');
if ($print>=2) { print "zmconv_org: $zmconv_org$eol"; }

#-----------------------------------------------------------------------------------------------
# Macro-physics package

Expand Down Expand Up @@ -1569,11 +1556,6 @@ else {
if ($print>=2) { print "Advected constituents added by $microphys_pkg microphysics: 10$eol"; }
}

if ($zmconv_org == 1 ) {
$nadv += 1;
if ($print>=2) { print "Advected constituents added by $microphys_pkg microphysics: 8$eol"; }
}

if ($clubb_do_adv) {
$nadv += 9;
if ($print>=2) { print "Advected constituents added by $microphys_pkg microphysics: 8$eol"; }
Expand Down Expand Up @@ -2344,6 +2326,8 @@ sub write_filepath
print $fh "$camsrcdir/src/atmos_phys/schemes/check_energy\n";
print $fh "$camsrcdir/src/atmos_phys/schemes/utilities\n";

print $fh "$camsrcdir/src/atmos_phys/schemes/cloud_fraction\n";

nusbaume marked this conversation as resolved.
Show resolved Hide resolved
# Dynamics package and test utilities
print $fh "$camsrcdir/src/dynamics/$dyn\n";
if($dyn eq 'se') {
Expand Down
3 changes: 0 additions & 3 deletions bld/namelist_files/namelist_defaults_cam.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2927,9 +2927,6 @@
<zmconv_ke hgrid="256x512" > 5.0E-6 </zmconv_ke>
<zmconv_ke hgrid="512x1024" > 5.0E-6 </zmconv_ke>

<zmconv_org > .false. </zmconv_org>
<zmconv_org zmconv_org="1" > .true. </zmconv_org>

<zmconv_num_cin > 5 </zmconv_num_cin>
<zmconv_num_cin phys="cam6" > 1 </zmconv_num_cin>
<zmconv_num_cin phys="cam7" > 1 </zmconv_num_cin>
Expand Down
7 changes: 0 additions & 7 deletions bld/namelist_files/namelist_definition.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3257,13 +3257,6 @@ Tunable evaporation efficiency in ZM deep convection scheme.
Default: set by build-namelist
</entry>

<entry id="zmconv_org" type="logical" category="conv"
group="zmconv_nl" valid_values="" >
Include organization parameterization in ZM. This value is set to true automatically
if -zmconv_org is set in configure.
Default: .false., unless -zmconv_org set in configure
</entry>

<entry id="zmconv_num_cin" type="integer" category="conv"
group="zmconv_nl" valid_values="" >
The number of negative buoyancy regions that are allowed before the convection top and CAPE calculations are completed.
Expand Down
Loading