cam6_4_065: ZM CCPP'ization round 4 (completes CCPP conversion of ZM) #1218
Conversation
Merge pull request ESCOMP#1078 from jedwards4b/update_config_component0705
There was a problem hiding this comment.
Thanks @cacraigucar! I went through this PR first since I pulled a few of the changes in this PR into my Hack shallow convection work. I just had two (hopefully easy to resolve) questions (on the water vapor standard name and another on cloud_fraction_fice).
…to cam_zm_cleanup4
Nitrogen depostion fluxes to surface models
There was a problem hiding this comment.
Good work @cacraigucar! I have some suggestions, but most should hopefully be pretty straight-forward. The one possible exception is the request to remove references to zmconv_org from the configure and definition.xml files, so if you run into any problems or issues with that or any other suggestion I have just let me know. Thanks!
| call phys_getopts (macrop_scheme_out = macrop_scheme) | ||
| if ( .not. (macrop_scheme == "rk" .or. macrop_scheme == "SPCAM_sam1mom")) top_lev = trop_cloud_top_lev | ||
|
|
||
| call cloud_fraction_fice_run(ncol, state1%t(1:ncol,:), tmelt, top_lev, pver, fice(1:ncol,:), fsnow_conv(1:ncol,:)) |
There was a problem hiding this comment.
I wouldn't worry about it for this PR, but I believe that cloud_fraction_fice_run should also be returning an error message and error code. Maybe worth opening an issue in the atmospheric_physics repo?
There was a problem hiding this comment.
I will be working on convect_shallow.F90 for Hack and the rest of cloud_fraction for RK so I can (eventually) bundle this in with one of my PRs, so if the issue is opened please feel free to assign it to me.
There was a problem hiding this comment.
Made issue in atmos_phys; ESCOMP/atmospheric_physics#201
src/physics/cam/zm_conv_intr.F90
Outdated
| @@ -142,14 +141,8 @@ subroutine zm_conv_register | |||
| ! detrained convective cloud water mixing ratio. | |||
| call pbuf_add_field('DLFZM', 'physpkg', dtype_r8, (/pcols,pver/), dlfzm_idx) | |||
| ! detrained convective cloud ice mixing ratio. | |||
There was a problem hiding this comment.
I believe the wrong comment was deleted here:
| ! detrained convective cloud ice mixing ratio. | |
| ! convective mass fluxes |
There was a problem hiding this comment.
Modified comment
There was a problem hiding this comment.
Sorry, but it looks like the wrong comment was updated. We want to keep the detrained convective cloud water mixing ratio. and instead replace detrained convective cloud ice mixing ratio. below it with convective mass fluxes.
src/physics/cam/zm_conv_intr.F90
Outdated
| @@ -142,14 +141,8 @@ subroutine zm_conv_register | |||
| ! detrained convective cloud water mixing ratio. | |||
| call pbuf_add_field('DLFZM', 'physpkg', dtype_r8, (/pcols,pver/), dlfzm_idx) | |||
| ! detrained convective cloud ice mixing ratio. | |||
There was a problem hiding this comment.
Sorry, but it looks like the wrong comment was updated. We want to keep the detrained convective cloud water mixing ratio. and instead replace detrained convective cloud ice mixing ratio. below it with convective mass fluxes.
Merge pull request ESCOMP#1226 from sjsprecious/fix_broken_gpu_tests
cacraigucar
changed the title
Merge pull request ESCOMP#1218 from cacraigucar/cam_zm_cleanup4 cam6_4_065: ZM CCPP'ization round 4 (completes CCPP conversion of ZM) ESCOMP commit: 3eb2112
This round of cleanup completes moving ZM to CCPP
closes #873