Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pymongo): use json for mongodb.query so it can be parsed by agent #12311

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(pymongo): use json for mongodb.query so it can be parsed by agent #12311

wants to merge 5 commits into from
+8 −4

Conversation

ajgajg1134
Copy link

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

releasenotes/notes/fix-pymongo-mongodb-query-span-tag-for-agent-230c3205d683ffd2.yaml  @DataDog/apm-python
ddtrace/contrib/internal/pymongo/client.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/pymongo/test.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: andrew.glaude/mongotag
Commit report: eba91da
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 28.16s Total duration (25m 48.86s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-02-14 23:00:21

Comparing candidate commit ba8b9ae in PR branch andrew.glaude/mongotag with baseline commit 043afbf in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@wantsui wantsui mentioned this pull request Feb 13, 2025
Merged
2 tasks
wantsui added a commit that referenced this pull request Feb 14, 2025
@wantsui
chore(pymongo): add additional asserts on resource names and mongodb.…
957ebc4 
…query span tag (#12333)

In preparation of @ajgajg1134 's
#12311, this PR adds
additional asserts for the current state of mongodb resource names and
mongodb.query.

Right now the tests show that there's a diff of `"` and `'` in the
current behavior.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@ajgajg1134 ajgajg1134 marked this pull request as ready for review February 14, 2025 21:41
@ajgajg1134 ajgajg1134 requested review from a team as code owners February 14, 2025 21:41
@wantsui wantsui changed the title use json for mongodb.query so it can be parsed by agent fix(pymongo): use json for mongodb.query so it can be parsed by agent Feb 14, 2025
@wantsui wantsui requested a review from a team as a code owner February 14, 2025 22:10
@wantsui wantsui requested a review from quinna-h February 14, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmettbutler emmettbutler Awaiting requested review from emmettbutler emmettbutler is a code owner automatically assigned from DataDog/apm-core-python

@wconti27 wconti27 Awaiting requested review from wconti27 wconti27 is a code owner automatically assigned from DataDog/apm-idm-python

@quinna-h quinna-h Awaiting requested review from quinna-h

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajgajg1134 @wantsui