Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pymongo): add additional asserts on resource names and mongodb.query span tag #12333

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Feb 13, 2025

In preparation of @ajgajg1134 's #12311, this PR adds additional asserts for the current state of mongodb resource names and mongodb.query.

Right now the tests show that there's a diff of " and ' in the current behavior.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wantsui wantsui requested review from a team as code owners February 13, 2025 20:29
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/pymongo/test.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python

@wantsui wantsui marked this pull request as draft February 13, 2025 20:30
@wantsui wantsui marked this pull request as ready for review February 13, 2025 20:31
Copy link

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 13, 2025
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/add-pymongo-tests-resource-name-mongodb-query
Commit report: b13dd94
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 19.4s Total duration (25m 26.84s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Benchmark execution time: 2025-02-14 19:41:20

Comparing candidate commit a65cce8 in PR branch wantsui/add-pymongo-tests-resource-name-mongodb-query with baseline commit 1151323 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 408 metrics, 0 unstable metrics.

@wantsui wantsui enabled auto-merge (squash) February 14, 2025 18:52
@wantsui wantsui merged commit 957ebc4 into main Feb 14, 2025
265 of 267 checks passed
@wantsui wantsui deleted the wantsui/add-pymongo-tests-resource-name-mongodb-query branch February 14, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants