Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Update waitForBlock #1068

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Test: Update waitForBlock #1068

merged 3 commits into from
Dec 17, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 12, 2024

Modify python integration test Node.waitForBlock to wait on blockNum instead of blockNum+1.

Resolves #1055

@heifner heifner requested review from greg7mdp and linh2931 December 12, 2024 19:16
@heifner heifner added the OCI Work exclusive to OCI team label Dec 12, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Modify python integration test Node.waitForBlock to wait on blockNum instead of blockNum+1.
Note:end

@heifner heifner merged commit 2c1f812 into main Dec 17, 2024
36 checks passed
@heifner heifner deleted the GH-1055-waitForBlock branch December 17, 2024 19:59
@heifner heifner mentioned this pull request Dec 18, 2024
Merged
heifner added a commit that referenced this pull request Jan 2, 2025
@heifner
GH-570 Fix for merge of #1068
12798d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test: Node.waitForBlock waits on next block
4 participants
@heifner @ericpassmore @greg7mdp @linh2931