Test: Wait for finalization to verify fund transfers #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-if has an irreversible node, wait for finalization before validation.
linh2931
reviewed
Dec 18, 2024
| @@ -100,7 +100,8 @@ | |||
| errorExit("Accounts creation failed.") | |||
|
|
|||
| Print("Spread funds and validate") | |||
| if not cluster.spreadFundsAndValidate(10): | |||
| # if activateIF then irreversible node needs funds to be irreversible before validation | |||
| if not cluster.spreadFundsAndValidate(10, waitForFinalization=activateIF): | |||
There was a problem hiding this comment.
so if activeateIF, will always wait for finalization even in head and speculative modes?
linh2931
approved these changes
Dec 18, 2024
greg7mdp
approved these changes
Dec 18, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
distributed-transactions-test.pyrunning with--activate-ifhas anirreversiblenode, wait for finalization of distributed funds before validation.Test instability seems to have been caused by the combination of #1068 and #1036.
#1068 - Changed
waitForBlockto not wait on an extra block.#1036 - Changed
distibuted-transactions-test.pyto have anirreversiblenode when--activate-if.Resolves #1078