Posix lvgl fixes #2812
Merged
Posix lvgl fixes #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
force-pushed
the
posix-lvgl-fixes
branch
from
6cd3425 to
d78b298
Compare
|
Tested with https://github.com/caksoylar/zmk-posix-testbed/tree/non-interactive, on |
An SDL/Zephyr bug prevents proper display when SDL calls are made from anything but the main thread, so add task handling in our simple main function when on POSIX.
Properly handle differences in the size of `size_t` on 64-bit architectures.
Some targets may be using color displays, so instead of forcing on the mono theme, merely imply it to default it
petejohanson
force-pushed
the
posix-lvgl-fixes
branch
from
d78b298 to
933ed92
Compare
Thanks for testing! I had to add a few more fixes to allow later updates to only be run on the main thread as well, by disabling our normal ticks/work when on POSIX, if you're up for one more quick test. |
5 tasks
|
Just got to testing the new version, seems to work fine here stil. |
tjmitchem
pushed a commit
to tjmitchem/zmk
that referenced
this pull request
Feb 12, 2025
fix(display): Do LVGL task processing in main on POSIX. An SDL/Zephyr bug prevents proper display when SDL calls are made from anything but the main thread, so add task handling in our simple main function when on POSIX. fix(usb): Compilation fix for 64-bit targets Properly handle differences in the size of `size_t` on 64-bit architectures. fix(display): Imply, but don't force, LVGL mono theme Some targets may be using color displays, so instead of forcing on the mono theme, merely imply it to default it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@caksoylar Can you test this there as well? These fixes were needed for me to get LVGL working properly on
native_posix_64target here.PR check-list