Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kscan): Remove warning when charlieplex is built without CONFIG_PM_DEVICE #2808

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

Nick-Munnich
Copy link
Contributor

@Nick-Munnich Nick-Munnich commented Feb 1, 2025

kscan_charlieplex_disconnect_all is only used within a CONFIG_PM_DEVICE block, so if the firmware is built without the flag it spits out a warning.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@Nick-Munnich Nick-Munnich requested a review from a team as a code owner February 1, 2025 16:58
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@petejohanson petejohanson merged commit 8e065d5 into zmkfirmware:main Feb 1, 2025
22 checks passed
@Nick-Munnich Nick-Munnich deleted the charlieplex-pm-fix branch February 1, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants