Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(display): Only default mono theme when 1bpp #2804

Merged

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Feb 1, 2025

In order to have flexibility for color displays, only imply the mono theme if we have 1bpp.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

In order to have flexibility for color displays, only imply the mono
theme if we have 1bpp.
@petejohanson petejohanson self-assigned this Feb 1, 2025
@petejohanson petejohanson requested a review from a team as a code owner February 1, 2025 03:47
@petejohanson petejohanson merged commit 425256b into zmkfirmware:main Feb 1, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant