spec_includes/ -> spec/, spec -> spec/spec #2422
Open
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensldm
reviewed
Jan 12, 2025
AngheloAlf
approved these changes
Jan 13, 2025
fig02
reviewed
Jan 13, 2025
There was a problem hiding this comment.
This really should have been a comment for #2399
But _gc_ique is pretty confusing. I figured after some more thought that it means "gc AND ique", but seeing it alongside _ique_n64 makes it seem like its saying there is a gamecube and n64 ique variant lol
Im not sure how to address this other than putting the word "and". Also understand if this conversation/change should happen elsewhere.
fig02
approved these changes
Jan 13, 2025
Dragorn421
added
Met Review Requirements
and removed
Needs first approval
Needs second approval
labels
|
was hoping to get a bit more than 2 approvals on this kind of change, but I guess there hasnt been any negative comments either. Will merge in 48-ish hours if there is no more activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.