Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add extensive externally hosted docs #177
base: dev
Are you sure you want to change the base?
docs: add extensive externally hosted docs #177
Changes from 40 commits
8003399
5011f23
19db053
2779ae9
6570e36
6b6a39a
f85a648
21c571d
25d1291
fc22d04
dc26daa
06b4ce1
5724434
0b22ff3
acef1cf
ed8aeeb
0f9a991
ea99f3c
caa9cad
1e98a25
b631f14
caefd94
588d6a6
2c4562c
caae76f
f5b780e
062005f
984b266
3221b08
339b9d2
82cbf0c
e9a7979
8b2d32f
32e37ca
f7162e3
96f9bc0
91a29f2
6a0a7aa
1dc9bbe
b67cb2b
40fa1cb
fce4260
95b18c7
3684cd1
d7af25e
e6961e7
f1e00f5
625edfd
53ed475
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test that pulls a zarp docker image and runs a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool to add a Dockerfile, test and docs for that, but I think that should go in a separate PR, if you don't mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, moving it to another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the previous statement doesn't make sense if you remove this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to github website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having to scroll down 193 lines to find a link to the ZARP docs is a bit strange. At this point readers might be convinced they have actually been reading the ZARP docs.
I would drastically shorten this document (just leave the absolute highlights)section and put a link to the docs in a much more prominent position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it similar to zarp-cli