Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Google Analytics (GA) from the site #845

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 24, 2025

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:

What changes did you make?

Deletes the google-analytics.com tracking script altogether.

Fixes #835.

Is there anything you'd like reviewers to focus on?

I can't run the site locally right now per #833 🙃 so someone should definitely validate that I didn't miss anything. I searched for ga, google.+analytics, etc. and this was the only line that came up for GA besides docs in app/misc/insight.md.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for yeoman ready!

Name Link
🔨 Latest commit 15495a4
🔍 Latest deploy log https://app.netlify.com/sites/yeoman/deploys/6797849024268d00080e084b
😎 Deploy Preview https://deploy-preview-845--yeoman.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mischah mischah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I added another commit to this branch. Feel free to squash wenn merging 😗

Co-authored-by: Ulises Gascón <[email protected]>
@JoshuaKGoldberg JoshuaKGoldberg merged commit 23a740d into yeoman:main Jan 27, 2025
6 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-google-analytics branch January 27, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Google Analytics (GA) and any other info-gathering from the site
4 participants