-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRF-TEB integration #1064
base: develop
Are you sure you want to change the base?
WRF-TEB integration #1064
Conversation
@dmey @dudhia @weiwangncar @barlage Here is a link to the page describing the Physics Review Process: |
@dudhia @davegill @weiwangncar @barlage should I go ahead and send a letter of intent (LOI) to the Physics Review Panel (PRP) (e-mail: [email protected])? It looks like the statements on the LOI are a subset of those in the paper already. Else we could simply share the the paper/summary of it as it includes more. |
@dudhia @barlage @weiwangncar |
@dmey @dudhia @weiwangncar @barlage
What does "external library" mean? Is this a separately compiled set of files that produce a Unix library file? Is this just a way of referring to a traditional subroutine call? |
We pushed it off till after the release, so now is the time to get back to
this on the WPRP.
…On Wed, Jun 17, 2020 at 7:59 AM Dave Gill ***@***.***> wrote:
@dmey <https://github.com/dmey> @dudhia <https://github.com/dudhia>
@weiwangncar <https://github.com/weiwangncar> @barlage
<https://github.com/barlage>
This PR includes all the files modified in WRF as well as the wrapper for
TEB phys/module_sf_teb.F used to integrate TEB model (
https://github.com/teb-model/teb) as an external library into WRF.
What does "external library" mean? Is this a separately compiled set of
files that produce a Unix library file? Is this just a way of referring to
a traditional subroutine call?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1064 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77D4ECBN63VNJWGHCBDRXDD4TANCNFSM4KMC7FGA>
.
|
@davegill a library dependency similarly to what is already done with other external libraries such as libnetcdf. TEB is therefore installed first on the system and then linked against if the user wishes to use the coupled WRF-TEB. I have detailed this more fully in section 4.1 in https://doi.org/10.1029/2019ms001961. Actual installation instructions on how to do this are in |
Yes, the build is certainly different, and we would like an explanation of
why it can't
be done similarly to the other physics in WRF,
Jimy
…On Thu, Jun 18, 2020 at 6:08 AM dmey ***@***.***> wrote:
What does "external library" mean? Is this a separately compiled set of
files that produce a Unix library file? Is this just a way of referring to
a traditional subroutine call?
@davegill <https://github.com/davegill> a library dependency similarly to
what is already done with other external libraries such as libnetcdf. TEB
is therefore installed first on the system and then linked against if the
user wishes to use the coupled WRF-TEB. I have detailed this more fully in
section 4.1 in https://doi.org/10.1029/2019ms001961. Actual installation
instructions on how to do this are in external/teb/README.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1064 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77DERKSWHFWIKZSMBR3RXH7TTANCNFSM4KMC7FGA>
.
|
Section 4 -- Software Implementation -- should explain. |
OK, we can ask Dave for his expert opinion on that
or any questions he has.
Thanks,
Jimy
…On Thu, Jun 18, 2020 at 9:37 AM dmey ***@***.***> wrote:
Yes, the build is certainly different, and we would like an explanation of
why it can't be done similarly to the other physics in WRF, Jimy
Section 4 -- Software Implementation -- should explain.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1064 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77D5Q6EGLVCOTTTW6NDRXIYBTANCNFSM4KMC7FGA>
.
|
@dmey Do you have an interest to incorporate TEB urban model to NoahMP? I'm asking this since going forward most development on the land model will be on NoahMP. |
@weiwangncar I was not planning to do this. I am also not familiar with the NoahMP code but if you can spare some help, maybe this is something that we can plan for a separate PR? |
TYPE
New feature
KEYWORDS
urban, town energy balance, land surface, software development
SOURCE
Meyer, D., Schoetter, R., Riechert, M., Verrelle, A., Tewari, M., Dudhia, J., Masson, V., Reeuwijk, M., & Grimmond, S. (2020). WRF‐TEB: implementation and evaluation of the coupled Weather Research and Forecasting (WRF) and Town Energy Balance (TEB) model. Journal of Advances in Modeling Earth Systems. https://doi.org/10.1029/2019ms001961
DESCRIPTION OF CHANGES
WRF-TEB (Meyer et al., 2020a) couples the single layer Town Energy Balance (TEB) model (Masson, 2000, and subsequent papers) model, software (Meyer et al., 2020b), to the Weather Research and Forecasting (WRF; Skamarock et al., 2019).
This PR includes all the files modified in WRF as well as the wrapper for TEB
phys/module_sf_teb.F
used to integrate TEB model (https://github.com/teb-model/teb) as an external library into WRF.The implementation here reflects what is in Meyer et al., 2020a with WRF-CMake (Riechert and Meyer, 2010). The entry point for TEB is
phys/module_sf_teb.F
which callssrc/driver/modd_wrf_teb_driver.F90
from the TEB model repository https://github.com/teb-model/teb. Information on how to install and run WRF-TEB are included inexternal/teb/README.md
.References
LIST OF MODIFIED FILES:
TESTS CONDUCTED
TODO -- @davegill I have already carried out tests and I will update this but please clarify if you want bit-for-bit identical output files in which case we would need remove the following from history/have them on only when TEB is enabled.