-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Localization #259
Open
sergikhizanishvili
wants to merge
21
commits into
v1.4
Choose a base branch
from
sergikhizanishvili/eng-2045-localize-the-ui
base: v1.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UI Localization #259
sergikhizanishvili
wants to merge
21
commits into
v1.4
from
sergikhizanishvili/eng-2045-localize-the-ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to return early from the `getSelectedGutenbergBlock` function if the `wp` object is undefined. This change guards against potential runtime errors when `wp` is not available in the execution context.
Added a check to return early if wp is undefined to avoid potential errors. This ensures the callback is only executed when the wp object is properly initialized.
Reorganized the React component hierarchy to place `ChatApp` inside a shadow DOM root element. Added an ID to the shadow DOM root element for improved identification and potential styling. Simplified the nesting structure for better readability and maintainability.
Updated the container for DropdownMenuPrimitive.Portal to target the shadow DOM element within the '#agentwp-chat-shadow-root' instead of the global window object. This change ensures the dropdown menu integrates properly within the encapsulated shadow DOM.
ENG-2065 - move dropdown inside the shadow root
Update base CSS with base wp admin font size anc color
ENG-2050: Add a check for unexecuted actions to display the thinking component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.