Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7311 [Multi tier] Remove specific parts of text in renewal banners #7337

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Feb 26, 2025

Description

Change specific text from renewal banners.

Fixes #7311

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Check #7311

What was tested

Tested for multiple user licence type, exipration date.
Tested for user with expired licence, expiring soon licence
Tested for user with auto renewal

How to test

You can mock user data with this and try out different options.

Technical description

Documentation

Changed the renewal banner text for infinite licence user.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Khadreal Khadreal self-assigned this Feb 26, 2025
Copy link

codacy-production bot commented Feb 26, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 573e2741 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (573e274) Report Missing Report Missing Report Missing
Head commit (0e3ddca) 39053 17110 43.81%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7337) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal requested a review from a team February 26, 2025 17:21
Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Khadreal @Miraeld

A few requested changes.

Can u also plz share screenshots of those changed messages so @marija-nikolic can check and validate? this will make the process faster.

Thanks again.

@Khadreal
Copy link
Contributor Author

Khadreal commented Feb 27, 2025

@marija-nikolic here are screenshots
Screenshot 2025-02-27 at 12 25 28
Screenshot 2025-02-27 at 12 35 38
Screenshot 2025-02-27 at 12 37 26
Screenshot 2025-02-27 at 15 28 28

Non-infinite user
Screenshot 2025-02-27 at 15 26 18

@marija-nikolic
Copy link
Collaborator

Quote reply

@Khadreal Please remove the "RENEW NOW" text that appears below the copy on the three banners. The Renew Now text should only appear on the CTA button, so we don’t need it as a separate line below the main copy.
image

@Khadreal
Copy link
Contributor Author

Khadreal commented Mar 2, 2025

@marija-nikolic please see the updated banner
Screenshot 2025-03-02 at 21 29 45
Screenshot 2025-03-02 at 21 31 37
Screenshot 2025-03-02 at 21 32 52

@marija-nikolic
Copy link
Collaborator

marija-nikolic commented Mar 3, 2025

@marija-nikolic please see the updated banner Screenshot 2025-03-02 at 21 29 45 Screenshot 2025-03-02 at 21 31 37 Screenshot 2025-03-02 at 21 32 52

Thanks, it looks ok, but shouldn’t the button be vertically centered within the banner, aligned with the middle of the text block?

@Khadreal
Copy link
Contributor Author

Khadreal commented Mar 3, 2025

@marija-nikolic the updated the banner, let me know what you think ?
Screenshot 2025-03-03 at 15 07 39
Screenshot 2025-03-03 at 15 08 05
Screenshot 2025-03-03 at 15 08 35

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 573e2741 33.33% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (573e274) Report Missing Report Missing Report Missing
Head commit (2b93138) 39071 17115 43.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7337) 60 20 33.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multi-tier] - Remove specific parts of text in renewal banners
4 participants