-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #7311 [Multi tier] Remove specific parts of text in renewal banners #7337
base: develop
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requested changes.
Can u also plz share screenshots of those changed messages so @marija-nikolic can check and validate? this will make the process faster.
Thanks again.
tests/Fixtures/inc/Engine/License/Renewal/displayRenewalExpiredBanner.php
Show resolved
Hide resolved
@marija-nikolic here are screenshots |
@Khadreal Please remove the "RENEW NOW" text that appears below the copy on the three banners. The Renew Now text should only appear on the CTA button, so we don’t need it as a separate line below the main copy. |
@marija-nikolic please see the updated banner |
Thanks, it looks ok, but shouldn’t the button be vertically centered within the banner, aligned with the middle of the text block? |
@marija-nikolic the updated the banner, let me know what you think ? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Description
Change specific text from renewal banners.
Fixes #7311
Type of change
Detailed scenario
Check #7311
What was tested
Tested for multiple user licence type, exipration date.
Tested for user with expired licence, expiring soon licence
Tested for user with auto renewal
How to test
You can mock user data with this and try out different options.
Technical description
Documentation
Changed the renewal banner text for infinite licence user.
New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style