Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ignored libraries #52

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Rework ignored libraries #52

merged 2 commits into from
Nov 20, 2023

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Nov 19, 2023

No description provided.

@sonnyp sonnyp requested a review from AkshayWarrier November 19, 2023 12:15
@sonnyp sonnyp marked this pull request as draft November 20, 2023 09:19
Comment on lines -45 to +47
"cp -a /usr/share/runtime/docs/gtk-doc/html/ /app/share/doc/"
"cp -a /usr/share/runtime/docs/gtk-doc/html/webkitgtk-6.0 /app/share/doc",
"cp -a /usr/share/runtime/docs/gtk-doc/html/javascriptcoregtk-6.0 /app/share/doc",
"cp -a /usr/share/runtime/docs/gtk-doc/html/webkitgtk-web-process-extension-6.0 /app/share/doc"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a bug, they should probably already be in docs/doc

I will file a bug. This will make the app a bit smaller. I verified, there are no other docs in html that we can use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should also stop copying everything share/doc because we use very little of it actually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it makes sense to only copy what we need from gtk-doc/html instead of copying everything and then ignoring irrelevant libraries

@sonnyp sonnyp changed the title Do not filter libraries Rework ignored libraries Nov 20, 2023
@sonnyp sonnyp marked this pull request as ready for review November 20, 2023 15:43
];
// Biblioteca is GTK4 only; these are GTK 3 libraries
// we only support gi-docgen and gtk3 uses gtk-doc
const IGNORED_LIBRARIES = ["atk", "libhandy-1"];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we are keeping libnotify? I thought GNotification covers all that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah no strong opinion 🤷

@AkshayWarrier AkshayWarrier merged commit 55a0e60 into main Nov 20, 2023
@AkshayWarrier AkshayWarrier deleted the sonnyp/no-ignore-libraries branch November 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants