-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework ignored libraries #52
Conversation
"cp -a /usr/share/runtime/docs/gtk-doc/html/ /app/share/doc/" | ||
"cp -a /usr/share/runtime/docs/gtk-doc/html/webkitgtk-6.0 /app/share/doc", | ||
"cp -a /usr/share/runtime/docs/gtk-doc/html/javascriptcoregtk-6.0 /app/share/doc", | ||
"cp -a /usr/share/runtime/docs/gtk-doc/html/webkitgtk-web-process-extension-6.0 /app/share/doc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be a bug, they should probably already be in docs/doc
I will file a bug. This will make the app a bit smaller. I verified, there are no other docs in html
that we can use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we should also stop copying everything share/doc
because we use very little of it actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think it makes sense to only copy what we need from gtk-doc/html
instead of copying everything and then ignoring irrelevant libraries
]; | ||
// Biblioteca is GTK4 only; these are GTK 3 libraries | ||
// we only support gi-docgen and gtk3 uses gtk-doc | ||
const IGNORED_LIBRARIES = ["atk", "libhandy-1"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we are keeping libnotify? I thought GNotification covers all that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah no strong opinion 🤷
No description provided.