Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Github Enterprise #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlawton
Copy link

@jlawton jlawton commented Mar 13, 2020

I changed the way the repository URL is constructed slightly. Saving in Automator also changed the QuickLook thumbnail (which I kept because I don't want to fight the tools) and the line endings in the script, which I'm okay with, because I think it's more readable on GitHub now.

The change was to use

sed -E -e 's,git@,https://,' -e 's,:([^/]),/\1,' -e 's,.git$,,'

rather than

sed 's/ssh:\/\/git@/https:\/\//' | sed 's/git@/https:\/\//' | sed 's/com:/com\//' | sed 's/\.git//'

I think the change to use , as the delimiter makes the regex easier to read (less escaping) but also, I don't assume the host name ends in com, which is not true of one of the Github Enterprise installations that I use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant