Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPB-15801 GET and DELETE Registered Domains #4438

Merged
merged 14 commits into from
Feb 3, 2025
Merged

WPB-15801 GET and DELETE Registered Domains #4438

merged 14 commits into from
Feb 3, 2025

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jan 31, 2025 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Jan 31, 2025
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 31, 2025
@battermann battermann marked this pull request as ready for review February 3, 2025 10:17
pcapriotti
pcapriotti reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great commit history, it was a pleasure to review. Just one comment on the GET query.

libs/wire-subsystems/src/Wire/DomainRegistrationStore/Cassandra.hs Outdated Show resolved Hide resolved
supersven
supersven approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@battermann battermann merged commit b0934a3 into develop Feb 3, 2025
11 checks passed
@battermann battermann deleted the WPB-15801-be-get-and-delete-registered-domains branch February 3, 2025 14:00
@zebot zebot mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti left review comments

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@battermann @pcapriotti @supersven @zebot