Add fast path to pathname start state #847
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular change adds a fast-path for implementors. We already use this in Ada (available at https://github.com/ada-url/ada/blob/main/src/parser.cpp#L650).
This change removes the performance penalty of URLs ending with
/
. As someone can imagine, it's pretty common for a user to send a request tohttps://ada-url.com/
.This particular change improved the performance of Ada ~9-10%. ada-url/ada#59
Preview | Diff