Improve integration with DOM's cloning steps #10859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponding DOM PR: whatwg/dom#1334.
dbaron
approved these changes
Dec 16, 2024
sideshowbarker
approved these changes
Dec 17, 2024
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Dec 17, 2024
Strictly speaking this should be an editorial change, but as it's fairly significant not marking it as such. This improves integration with HTML as well. All the arguments are exported as HTML needs them as well. And they are named parameters now for clarity. Corresponding HTML PR: whatwg/html#10859. Fixes #1219. Closes #1220.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 5, 2025
Reflects the changes in whatwg/html#10859 I've also added missing calls to the Base::cloned() method, and modified a couple of spec links to point to the multipage version.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 5, 2025
Reflects the changes in whatwg/html#10859 I've also added missing calls to the Base::cloned() method, and modified a couple of spec links to point to the multipage version. I took the liberty to fix a spec typo, and submitted a PR for it: whatwg/html#10892
tcl3
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Jan 5, 2025
Reflects the changes in whatwg/html#10859 I've also added missing calls to the Base::cloned() method, and modified a couple of spec links to point to the multipage version. I took the liberty to fix a spec typo, and submitted a PR for it: whatwg/html#10892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding DOM PR: whatwg/dom#1334.
/form-elements.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )
/scripting.html ( diff )
/urls-and-fetching.html ( diff )