-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: modernize how CustomElementRegistry is defined #10845
Conversation
@domenic I noticed that I should also tackle "look up a custom element definition", but I'll let you glance over this first to see if there's anything else missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks. Can't believe I wrote such old-looking stuff... :)
definition">custom element definitions</span>, initially empty. In general, algorithms in this | ||
specification look up elements in the registry by any of <span | ||
<p>Every <code>CustomElementRegistry</code> has a <dfn>custom element definition set</dfn>, a | ||
<span>set</span> of <span data-x="custom element definition">custom element definitions</span>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we needed to change the name of this, but I don't mind too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the name? This seemed consistent with the map member.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant "custom element definition set" (new name) vs. "custom element definitions" (old name). But yeah, seems fine.
/custom-elements.html ( diff )
/dom.html ( diff )