Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: modernize how CustomElementRegistry is defined #10845

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 10, 2024

@annevk annevk requested a review from domenic December 10, 2024 12:56
@annevk
Copy link
Member Author

annevk commented Dec 10, 2024

@domenic I noticed that I should also tackle "look up a custom element definition", but I'll let you glance over this first to see if there's anything else missing.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks. Can't believe I wrote such old-looking stuff... :)

definition">custom element definitions</span>, initially empty. In general, algorithms in this
specification look up elements in the registry by any of <span
<p>Every <code>CustomElementRegistry</code> has a <dfn>custom element definition set</dfn>, a
<span>set</span> of <span data-x="custom element definition">custom element definitions</span>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we needed to change the name of this, but I don't mind too much.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the name? This seemed consistent with the map member.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant "custom element definition set" (new name) vs. "custom element definitions" (old name). But yeah, seems fine.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@annevk annevk merged commit 4631f8b into main Dec 11, 2024
2 checks passed
@annevk annevk deleted the annevk/cer branch December 11, 2024 14:44
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Dec 18, 2024
AtkinsSJ added a commit to LadybirdBrowser/ladybird that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants