Skip to content

Commit

Permalink
Ensure we do a fragment navigated callback for any case where there w…
Browse files Browse the repository at this point in the history
…ill be no load event.

In particular if webdriver initiates a navigation to the current URL and it includes a fragment, this seems to
be required to ensure the navigation completes on the WebDriver side.
  • Loading branch information
jgraham committed Oct 13, 2021
1 parent 363878c commit 9afc0d6
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion source
Original file line number Diff line number Diff line change
Expand Up @@ -84930,7 +84930,7 @@ interface <dfn interface>History</dfn> {
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>source browsing context</var>'s <span>active
document</span>'s <span data-x="concept-document-url">URL</span>
document</span>'s <span data-x="concept-document-url">URL</span><span
data-x="navigation-status-url">url</span>.</p></li>

<li><p>Return.</p></li>
Expand Down Expand Up @@ -88584,6 +88584,23 @@ new PaymentRequest(&hellip;); // Allowed to use
data-x="navigation-status-complete">complete</code>".</p></li>
</ol>
</li>
<li><p>If <var>stateChanged</var> is false, <var>hashChanged</var> is false and
<var>entry</var>'s <span data-x="she-document">document</span> equals the
<span>current entry</span>'s <span data-x="she-document">document</span>, then:</p>

<!-- This ensures that a WebDriver-BiDi navigation to a URL identical to the current URL,
but where the URL has a fragment part, still emits a fragment navigated event. -->

<ol>
<li><p>Invoke <span>WebDriver BiDi fragment navigated</span> with <var>newDocument</var>'s
<span data-x="concept-document-bc">browsing context</span> and a new <span>WebDriver
BiDi navigation status</span> whose <span data-x="navigation-status-id">id</span> is
<var>navigationId</var>, <span data-x="navigation-status-url">url</span> is
<var>resource</var>'s <span data-x="concept-request-url">URL</span>, and <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-complete">complete</code>".</p></li>
</ol>
</li>
</ol>
</li>
</ol>
Expand Down

0 comments on commit 9afc0d6

Please sign in to comment.