Skip to content

Commit

Permalink
Fix review issues
Browse files Browse the repository at this point in the history
  • Loading branch information
jgraham committed Sep 15, 2021
1 parent 1fa8df3 commit 725ca64
Showing 1 changed file with 24 additions and 23 deletions.
47 changes: 24 additions & 23 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -84920,23 +84920,23 @@ interface <dfn interface>History</dfn> {
<li><p>Let <var>specified browsing context</var> be the <span>browsing context</span> of
the <var>specified entry</var>.</p></li>

<li><p>If <var>source browsing context</var> is not <span>allowed to navigate</span>
<var>specified browsing context</var>, then invoke <span>WebDriver BiDi navigation failed</span> with
with <var>source browsing context</var>, and a <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>resource</var>'s <span
data-x="concept-request-url">url</span>, then return.</p></li>
<li><p>If any of the following are true:</p>

<li><p>If the <var>specified browsing context</var>'s <span>active document</span>'s <span>unload
counter</span> is greater than 0, then invoke <span>WebDriver BiDi navigation failed</span> with
with <var>source browsing context</var>, and a <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>resource</var>'s <span
data-x="concept-request-url">url</span>, then return.</p></li>
<ol>
<li><p><var>Source browsing context</var> is not <span>allowed to navigate</span>
<var>specified browsing context</var>; or<p></li>

<li><p>The <var>specified browsing context</var>'s <span>active document</span>'s <span>unload
counter</span> is greater than 0.</p></li>
</ol>

<p>Then invoke <span>WebDriver BiDi navigation failed</span> with
with <var>source browsing context</var>, and a <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>resource</var>'s <span
data-x="concept-request-url">url</span>, and return.</p></li>

<li>
<p><span>Queue a global task</span> on the <span>history traversal task source</span> given
Expand Down Expand Up @@ -88264,7 +88264,7 @@ new PaymentRequest(&hellip;); // Allowed to use
data-x="traverse-history-hh"><var>historyHandling</var></dfn> (default "<code
data-x="hh-default">default</code>"), an optional boolean <dfn><var>nonBlockingEvents</var></dfn>
(default false), an optional boolean <dfn><var>explicitHistoryNavigation</var></dfn> (default
false), optional <span data-x="navigation-id">navigation id</span>
false), and an optional <span data-x="navigation-id">navigation id</span>
<dfn data-x="traverse-history-navigationid"><var>navigationId</var></dfn> (default null):</p>

<p class="note">This algorithm is not just invoked when <span data-x="traverse the history by a
Expand Down Expand Up @@ -88325,10 +88325,11 @@ new PaymentRequest(&hellip;); // Allowed to use
a WebDriver-initiated history traversal from the bfcache and a UA initated history traversal. -->
<ol>
<li><p>If <var>newDocument</var>'s <span data-x="concept-document-navigation-id">navigation
id</span> is not null, let <var>navigationId</var> be <var>newDocument</var>'s <span
data-x="concept-document-navigation-id">navigation id</span>. Otherwise let
<var>navigationId</var> be the result of <span>generating a random UUID</span>.
<ref spec=UUID></p></li>
id</span> is not null, set <var>navigationId</var> to <var>newDocument</var>'s <span
data-x="concept-document-navigation-id">navigation id</span>.

<li><p>Otherwise, set <var>navigationId</var> to the result of <span>generating a random
UUID</span>. <ref spec=UUID></p></li>
</ol>
</li>

Expand Down Expand Up @@ -88513,7 +88514,7 @@ new PaymentRequest(&hellip;); // Allowed to use
<span data-x="concept-document-bc">browsing context</span>, and a new <span>WebDriver
BiDi navigation status</span> whose <span data-x="navigation-status-id">id</span> is
<var>navigationId</var>, <span data-x="navigation-status-url">url</span> is
<var>resource</var>'s <span data-x="concept-request-url">url</span>, and <span
<var>resource</var>'s <span data-x="concept-request-url">URL</span>, and <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-complete">complete</code>".</p></li>
</ol>
Expand All @@ -88534,7 +88535,7 @@ new PaymentRequest(&hellip;); // Allowed to use
<span data-x="concept-document-bc">browsing context</span>, and a new <span>WebDriver
BiDi navigation status</span> whose <span data-x="navigation-status-id">id</span> is
<var>navigationId</var>, <span data-x="navigation-status-url">url</span> is
<var>resource</var>'s <span data-x="concept-request-url">url</span>, and <span
<var>resource</var>'s <span data-x="concept-request-url">URL</span>, and <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-complete">complete</code>".</p></li>
</ol>
Expand Down

0 comments on commit 725ca64

Please sign in to comment.