Return a content-encoding header for resource timing and more
#1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamr
reviewed
Jan 7, 2025
| @@ -5004,6 +5041,13 @@ steps: | |||
|
|
|||
| <li><p>Let <var>type</var> be <var>blob</var>'s {{Blob/type}}. | |||
|
|
|||
| <li><p>Let <var>accept-coding</var> be the result of <a for="header list">getting</a> | |||
| `<code>Accept-Encoding</code>` from <var>request</var>'s <a for=request>header list</a>. | |||
| @@ -5105,10 +5152,19 @@ steps: | |||
| <li><p>Let <var>mimeType</var> be <var>dataURLStruct</var>'s | |||
| <a for="data: URL struct">MIME type</a>, <a lt="serialize a MIME type to bytes">serialized</a>. | |||
|
|
|||
| <li><p>Let <var>accept-coding</var> be the result of <a for="header list">getting</a> | |||
| `<code>Accept-Encoding</code>` from <var>request</var>'s <a for=request>header list</a>. | |||
| <li><p>Let <var>accept-coding</var> be the result of <a for="header list">getting</a> | ||
| `<code>Accept-Encoding</code>` from <var>request</var>'s <a for=request>header list</a>. | ||
| If <var>accept-encoding</var> is not null and the server selects one of the encoding options, | ||
| let <var>coding</var> be the selected encoding option; otherwise, i.e., no encoding is used, |
There was a problem hiding this comment.
You can't have "let" in the middle of a phrase, see style in the rest of the document.
|
Thanks for taking the time to pick this up. However, it doesn't seem like this addresses all the issues with #1742? I recommend studying the feedback on that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change is to add
content-encodingto response header list. This PR also adds description on howcontent-encodingis determined. (content negotiation)The purpose is to pass such value to resource timing. Further details are available at
w3c/resource-timing#381.
Note: Per discussion at 12/05/2024 webPerWG call (https://docs.google.com/document/d/1mpFDrAWuV6IgvJ1KiL9sgIlcboC5uArtF8r_oqS1Sco/edit?tab=t.0#heading=h.af6v74wysf4m), we decided to allow arbitrary "content-encoding" value at "fetch". We only filter such value at client side, before passing the value to resource timing.
Related PR to modify resource timing specification:
w3c/resource-timing#411
At least two implementers are interested (and none opposed):
Likely, Discussed and agreed at Feb 29, 2024 W3C WebPerf call, Chromium already receiving content-encoding through fetch. But not sure about other browsers.
Tests are written and can be reviewed and commented upon at:
[to be updated with a new link] https://chromium-review.googlesource.com/c/chromium/src/+/5958411
Implementation bugs are filed:
Chromium: https://issues.chromium.org/issues/327941462
Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1886107
WebKit: https://bugs.webkit.org/show_bug.cgi?id=271632
Deno (not for CORS changes): …
MDN issue is filed:
New PerformanceResourceTiming.contentEncoding field mdn/content#32823
The top of this comment includes a clear commit message to use.
(See WHATWG Working Mode: Changes for more details.)
Bug: w3c/resource-timing#381
Preview | Diff