Fix #227: Make createEvent("touchevent") sometimes throw #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers typically disable touch events on non-touch devices, and there exists Web content that detects this difference using createEvent.
| in its current configuration, let <var>constructor</var> be null. | ||
|
|
||
| <p class=note>Typically user agents have the {{TouchEvent}} interface disabled in some | ||
| configurations. |
There was a problem hiding this comment.
Wouldn't this just follow from new TouchEvent throwing?
There was a problem hiding this comment.
Yes but that would result in a TypeError whereas WebKit/Chromium/Gecko (at last) throw NotSupportedError.
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4078
I suppose TypeError is Web compatible enough but are implementors OK with changing to TypeError?
There was a problem hiding this comment.
I see. I think it would be better then to where we talk about the initial value of constructor we check for that being undefined and if it's undefined we throw a NotSupportedError and mention that this can be the case for TouchEvent in a note.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers typically disable touch events on non-touch devices, and
there exists Web content that detects this difference using
createEvent.
Also see w3c/touch-events#64 for a possible spec hook for this.
I'm not sure about the wording, happy to tweak it.
I updated bikeshed and got some unrelated differences in the output, FYI.