Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for adding language filter to sync-ingredients management command. #1894

Merged
merged 19 commits into from
Feb 23, 2025

Conversation

scrapcode
Copy link
Contributor

Proposed Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
    • Seperated test for --languages feature to ensure correct URL is being called
  • Added yourself to AUTHORS.rst

Other questions

  • Do users need to run some commmands in their local instances due to this PR
    (e.g. database migration)? No

@rolandgeider
Copy link
Member

Thanks for the pr, will test it once I get home, but from a first glance it looks good

Copy link
Contributor Author

@scrapcode scrapcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed duplicate functionality I failed to remove in initial merge conflict.

@rolandgeider rolandgeider merged commit fcba450 into wger-project:master Feb 23, 2025
8 checks passed
@rolandgeider
Copy link
Member

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants