Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support global data variables #4870

Merged
merged 3 commits into from
Feb 14, 2025
Merged

feat: support global data variables #4870

merged 3 commits into from
Feb 14, 2025

Conversation

TrySound
Copy link
Member

Ref #4166 #3686

Added "Settings" section to global root. Now users can create data variables which are available for all pages and inside slots.

Screen.Recording.2025-02-14.at.13.29.29.mov

Ref #4166 #3686

Added "Settings" section to global root. Now users can create data
variables which are available for all pages and inside slots.
@TrySound TrySound requested review from kof and johnsicili February 14, 2025 05:32
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Finally!

What about system?

@TrySound
Copy link
Member Author

Another PR

@johnsicili
Copy link
Contributor

johnsicili commented Feb 14, 2025

Good work!!!

I noticed when duplicating or copy pasting an instance that references a global var, the data doesn't display even though the binding still seems to be correct.

Edit: Same with slots. Drag an instance with binding into a Slot, value no longer displays. Seems like the same root issue

copypasteglobal.mp4
  1. Bind Global data var value to a heading
  2. Duplicate heading
  3. See no text on duplicate

Still testing but passing this along for now

@TrySound TrySound merged commit 8ed3fbb into main Feb 14, 2025
17 checks passed
@TrySound TrySound deleted the global-vars branch February 14, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants