Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Search for advanced section in style panel #4862

Merged
merged 6 commits into from
Feb 14, 2025
Merged

feat: Search for advanced section in style panel #4862

merged 6 commits into from
Feb 14, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 12, 2025

#4805

Description

  1. start searching
  2. abort with esc
  3. try in default as well as in advanced mode
  4. try with recent changes and without

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from istarkov February 14, 2025 12:14
@kof kof marked this pull request as ready for review February 14, 2025 12:14
@kof kof requested a review from johnsicili February 14, 2025 12:14
@kof kof removed the request for review from istarkov February 14, 2025 18:58
@kof kof merged commit ecb23c0 into main Feb 14, 2025
17 checks passed
@kof kof deleted the advanced-search branch February 14, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants