Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Autocomplete values in advanced panel #4854

Merged
merged 6 commits into from
Feb 11, 2025
Merged

feat: Autocomplete values in advanced panel #4854

merged 6 commits into from
Feb 11, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 11, 2025

#4816

Description

  • When adding a new property, you sometimes don't know the property name, e.g. you know you want to "center" it but you don't remember if its align-items, align-content or any other and you need to see the list.
  • Currently you can create a css variable "bla" and it will bypass validation, now it will validate
  • also try "color" esc autocomplete, enter
  • or "color:red" esc autocomplete enter

Try typing "center"

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from TrySound and johnsicili February 11, 2025 00:30
@johnsicili
Copy link
Contributor

Can the values render on canvas as we arrow through them in autocomplete?

Showing values helps not just recall the names but also see what they do... I often do this with flex/grid alignment

@kof
Copy link
Member Author

kof commented Feb 11, 2025

Oh you mean the autocomplete upon property creation! Good call

@johnsicili
Copy link
Contributor

Like this:

previewrender.mp4

Every arrow over should render that option so we can see what it does IMO

@kof
Copy link
Member Author

kof commented Feb 11, 2025

yep, on it, it wasn't possible before I added the values to autocomplete and now it is!

@kof
Copy link
Member Author

kof commented Feb 11, 2025

@johnsicili added preview on highlight

Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE this is getting good

@kof kof merged commit 1e86e76 into main Feb 11, 2025
17 checks passed
@kof kof deleted the autocomplete-values branch February 11, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants