Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rate limit on shared link clicks #4715

Merged
merged 2 commits into from
Jan 5, 2025
Merged

fix: Rate limit on shared link clicks #4715

merged 2 commits into from
Jan 5, 2025

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jan 4, 2025

Description

closes #4403

We have no way to show good errors on naviagation errors (remix does not support this)

Here I reduced amount of reloads on link clicks on preview

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from TrySound January 4, 2025 18:06
@istarkov istarkov merged commit 069376f into main Jan 5, 2025
9 checks passed
@istarkov istarkov deleted the reduce-loads branch January 5, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit shows as application error for share link projects
2 participants