Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental: SSG download support #3783

Merged
merged 9 commits into from
Jul 30, 2024
Merged

experimental: SSG download support #3783

merged 9 commits into from
Jul 30, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jul 23, 2024 •
edited
Loading

Description

See corresponding SaaS PR too

Steps for reproduction

Click Publish/Export

image

Deploy zip to netlify
image

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov temporarily deployed to postgres_production July 26, 2024 05:24 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_production July 26, 2024 06:05 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_production July 26, 2024 09:33 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_production July 26, 2024 09:45 — with GitHub Actions Inactive
@istarkov istarkov had a problem deploying to postgres_production July 26, 2024 09:46 — with GitHub Actions Failure
@istarkov istarkov temporarily deployed to postgres_production July 26, 2024 09:49 — with GitHub Actions Inactive
@istarkov istarkov had a problem deploying to postgres_production July 26, 2024 09:51 — with GitHub Actions Failure
@istarkov istarkov temporarily deployed to postgres_production July 26, 2024 09:52 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_development July 29, 2024 12:04 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_development July 29, 2024 12:28 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_development July 29, 2024 14:11 — with GitHub Actions Inactive
@istarkov istarkov requested review from TrySound and kof July 29, 2024 14:42
@istarkov istarkov marked this pull request as ready for review July 29, 2024 14:42
@istarkov istarkov changed the title experimental: Zip experimental: SSG download support Jul 29, 2024
@istarkov istarkov merged commit 8be665e into main Jul 30, 2024
31 checks passed
@istarkov istarkov deleted the pb.staging branch July 30, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istarkov @kof @TrySound