Skip to content

Commit

Permalink
feat: add offset-position and offset-anchor properties under adva…
Browse files Browse the repository at this point in the history
…nced section (#3970)

fixes #3963 

## Description
Adds `offset-position` property to be available under the advanced
section. Of all the `offset-*` properties. Looks like only `position` is
marked as experimental in `mdn-data`. But, according to can-i-use. It
seems it has a fair amount of support among browsers.
https://caniuse.com/mdn-css_properties_offset-position
![Screenshot 2024-08-20 at 11 44
59 AM](https://github.com/user-attachments/assets/ab080a22-4e94-453a-8587-38be95cc83dc)


## Steps for reproduction
- Add `offset-position` property under the advanced tab.
- check for description of the property.
- Ability to reset the property from the advanced tab.

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [x] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [x] tested locally and on preview environment (preview dev login:
5de6)
  • Loading branch information
JayaKrishnaNamburu authored Aug 21, 2024
1 parent 6a79e71 commit e5ec6a1
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/css-data/bin/mdn-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@ const experimentalProperties = [
"-webkit-tap-highlight-color",
"-webkit-overflow-scrolling",
"transition-behavior",
"offset-position",
// https://github.com/mdn/data/pull/759
// offset-anchor is standard according to mdn.
// But the mdn_url is missing from its config which is skipping othe starndard check.
"offset-anchor",
];

const unsupportedProperties = [
Expand Down
2 changes: 2 additions & 0 deletions packages/css-data/src/__generated__/animatable-properties.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions packages/css-data/src/__generated__/keyword-values.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions packages/css-data/src/__generated__/properties.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/css-engine/src/__generated__/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e5ec6a1

Please sign in to comment.