Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csharp test to identify .net fwk version #46

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

darrelmiller
Copy link

The version property previously used to identify the useragent only identified the CLR, not the framework version. I suspect the previous tests were run on .net 4.0. Running the tests on .Net 4.5 show a reasonable number of differences, including differences in how the [] are handled and how ipv6 addresses are rendered.

@rubys
Copy link
Member

rubys commented Jan 18, 2015

When I try compiling with this, I get

testuri.cs(67,60): error CS0246: The type or namespace name
        'TargetFrameworkAttribute' could not be found (are you missing a using
        directive or an assembly reference?)
testuri.cs(67,92): error CS0246: The type or namespace name
        'TargetFrameworkAttribute' could not be found (are you missing a using
        directive or an assembly reference?)

@rubys
Copy link
Member

rubys commented Jan 18, 2015

Looks like this may be new with .Net Framework 4.5. I'll try to update and see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants