Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: the minimum required Node.js version is 18.12.0 #4291

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Oct 15, 2024

What kind of change does this PR introduce?
build

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary

The minimum required Node.js version is 18.12.0

Does this PR introduce a breaking change?
Yes

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner October 15, 2024 15:26
@alexander-akait
Copy link
Member

@snitin315 Feel free to continue work in this branch on other next changes

@snitin315 snitin315 changed the base branch from master to next October 15, 2024 15:43
@snitin315
Copy link
Member Author

@alexander-akait Created separate next branch. Are you fine with the minimum version as 18.18.0?

@alexander-akait
Copy link
Member

Let's use :

"engines": {
    "node": ">= 18.12.0"
  },

@snitin315
Copy link
Member Author

@alexander-akait Done!

@snitin315 snitin315 changed the title build!: the minimum required Node.js version is 18.18.0 build!: the minimum required Node.js version is 18.12.0 Oct 16, 2024
@snitin315 snitin315 merged commit d983e55 into next Oct 21, 2024
43 checks passed
@snitin315 snitin315 deleted the build/drop-node branch October 21, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants