fix(service.js): apply the current browser object #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global browser object was used though WebdriverIO v8 supports importing the globals manually. This commit applies the current browser object that has all the properties it needs.
|
@wswebcreation I would like to apply this fix to version 3.1.1 as well and create a 3.1.2 version. How could we make this happen? :) |
|
Thanks for the PR, but not sure how to do that. Why not on the latest version |
|
This would be since we cannot upgrade in the project I currently work on. However we have found a solution on our side so such a release is no longer needed :) |
|
In order for the build to pass, the chromedriver version needs to be updated or one of the versioning options listed here should be applied. |
|
fixed in #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global browser object was used though WebdriverIO v8 supports importing the globals manually. This commit applies the current browser object that has all the properties it needs.