Use number input type as example for non-auto-directionality form-associated input element #49795
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gecko and WebKit do not support `type=month`, so use `type=number` as an example for an input type that is not [auto-directionality form-associated](https://html.spec.whatwg.org/#auto-directionality-form-associated-elements)
|
AFAICT this is reasonable since the original test doesn't really care what kind of form element it is. @dbaron is the original test author, so I'll give him a chance to comment before approving. |
|
Hi @dbaron , a gentle ping here to ensure it is still on your radar for review. Thank you. |
annevk
approved these changes
Jan 7, 2025
zcorpan
approved these changes
Jan 21, 2025
|
Merging without waiting further for @dbaron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subtest ensures that the text direction reverts to
ltrif an input element stops being auto-directionality form-associated. For this, the test changes an input element's type tomonth. Gecko and WebKit do not supporttype=monthand therefore fail the test. This change usestype=numberinstead so that both pass the subtest.