[reading-flow] display: contents participate in the flow #48611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From CSSWG resolution [1]: > display:contents focusable element occurs immediately before its first child in visual order [1] w3c/csswg-drafts#9230 (comment) Currently, reading flow items in display: contents are ignored and display: contents elements are visited last in the focus order. That means we lose that order information. We update the algorithm so when we loop reading items and find one that is not in the focus scope, we traverse its parent to find an ancestor that is. This element can then be added in the reading flow instead. We update A11Y to behave the same way as focus navigation. Since the A11Y tree uses LayoutTreeBuilder, we update the algorithm to loop through each reading flow item's ancestor until its parent is the LayoutTreeBuilderTraversal::Parent. This element can then be added in the reading flow instead. Change-Id: I1c3c3ab3a6548611af9a2cfddecc9d889b0ecb14 Bug: 371024057 Bug: 40932006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924454 Commit-Queue: Di Zhang <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1368523}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5924454
branch
from
2935338 to
887a2a1
Compare
wpt-pr-bot
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From CSSWG resolution [1]:
[1] w3c/csswg-drafts#9230 (comment)
Currently, reading flow items in display: contents are ignored and
display: contents elements are visited last in the focus order.
That means we lose that order information.
We update the algorithm so when we loop reading items and find one that
is not in the focus scope, we traverse its parent to find an ancestor
that is. This element can then be added in the reading flow instead.
We update A11Y to behave the same way as focus navigation. Since the
A11Y tree uses LayoutTreeBuilder, we update the algorithm to loop
through each reading flow item's ancestor until its parent is the
LayoutTreeBuilderTraversal::Parent. This element can then be added in
the reading flow instead.
Change-Id: I1c3c3ab3a6548611af9a2cfddecc9d889b0ecb14
Bug: 371024057
Bug: 40932006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924454
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1368523}