[Selection API] Implement selection.direction #47043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sefeng211, I have removed the click based tests from selection-direction.tentative.html because I believe the behavior tested is not interoperable across browsers nor OS. Could you help take a look? If you disagree, you can add the tests again with a link to spec/discussion. Thank you! 
|
Add selection.direction [1] which returns "none", "forward" or "backward". We also update the WPT test selection-direction.tentative.html to remove the selection click-based tests as this behavior is not standardized across browsers [2] [3]. [1] https://w3c.github.io/selection-api/#dom-selection-direction [2] w3c/selection-api#70 (comment) [3] w3c/selection-api#177 (comment) Change-Id: I2aad4f8efc4f3d700437501929af274116f7910a Bug: 40286116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5677331 Commit-Queue: Di Zhang <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1324573}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5677331
branch
from
f100dda to
32d08be
Compare
wpt-pr-bot
approved these changes
Jul 8, 2024
|
Okay, thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add selection.direction [1] which returns "none", "forward" or
"backward".
We also update the WPT test selection-direction.tentative.html
to remove the selection click-based tests as this behavior is not
standardized across browsers [2] [3].
[1] https://w3c.github.io/selection-api/#dom-selection-direction
[2] w3c/selection-api#70 (comment)
[3] w3c/selection-api#177 (comment)
Change-Id: I2aad4f8efc4f3d700437501929af274116f7910a
Bug: 40286116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5677331
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1324573}