Allow appHistory entries that are cross-site-instance, censor the url of entries that are noreferrer #31666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 17, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
3 times, most recently
from
87793b9 to
68bb957
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
from
68bb957 to
e7446fd
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
3 times, most recently
from
f031df2 to
3dd67d8
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
from
3dd67d8 to
ed20086
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
2 times, most recently
from
ea35341 to
5aefe72
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
3 times, most recently
from
d41227f to
f478c1a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
5 times, most recently
from
ebf1265 to
86bb2ae
Compare
… of entries that are noreferrer While this allows appHistory entries (including URLs) to be sent across renderer processes on a BrowsingContextGroup switch, it still omits the URL in cases where a page has expressed that the URL may be sensitive and shouldn't be exposed (via the document's last ReferrerPolicy). FrameNavigationEntry now stores a |protect_url_in_app_history| bit, which is updated when the referrer policy is set/changed. If the most recent referrer policy is "no-referrer" or "origin", the url will be censored in appHistory, as these policies indicate that the document set its referrer policy to hide its full url even from other same-origin documents. This follows WICG/navigation-api#71 Fixed: 1280010 Change-Id: I07e7ff1376dd9eca34b4493a06a658f1b72da027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283546 Reviewed-by: Domenic Denicola <[email protected]> Reviewed-by: Antonio Sartori <[email protected]> Reviewed-by: Charles Reis <[email protected]> Commit-Queue: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#961643}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3283546
branch
from
86bb2ae to
d74fe96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this allows appHistory entries (including URLs) to be sent across
renderer processes on a BrowsingContextGroup switch, it still omits the
URL in cases where a page has expressed that the URL may be sensitive
and shouldn't be exposed (via the document's last ReferrerPolicy).
FrameNavigationEntry now stores a |protect_url_in_app_history| bit,
which is updated when the referrer policy is set/changed. If the
most recent referrer policy is "no-referrer" or "origin", the url
will be censored in appHistory, as these policies indicate that the
document set its referrer policy to hide its full url even from other
same-origin documents.
This follows WICG/navigation-api#71
Fixed: 1280010
Change-Id: I07e7ff1376dd9eca34b4493a06a658f1b72da027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283546
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Antonio Sartori <[email protected]>
Reviewed-by: Charles Reis <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#961643}