Remove document.createEvent("touchevent") #27250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cynthia@ could you please take a look, thank you. |
Ms2ger
requested changes
Jan 20, 2021
touch-events/historical.html
Outdated
Comment on lines
39
to
41
| var touchEvent = document.createEvent("touchevent"); | ||
| assert_false("initTouchEvent" in touchEvent, | ||
| "Should not be supported on the instance"); |
There was a problem hiding this comment.
Keep this test, but use the constructor to create touchEvent instead.
LanWei22
commented
Jan 20, 2021
touch-events/historical.html
Outdated
Comment on lines
39
to
41
| var touchEvent = document.createEvent("touchevent"); | ||
| assert_false("initTouchEvent" in touchEvent, | ||
| "Should not be supported on the instance"); |
|
This is still exposed on mobile as it happens. Properly specifying this in the DOM Standard depends on w3c/touch-events#64. I'm not sure how we would expose that boolean in tests though. |
Ms2ger
approved these changes
Jan 21, 2021
|
@annevk gah, didn't see your comment before merging. Lemme know if I should revert. |
|
I think it's fine. Once that issue is fixed we'll need to have another look at this and for desktop these are the correct results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in DOM spec, createEvent(interface) is not recommended and suggests "Event constructors ought to be used instead." Also, Chrome, Edge, Firefox and Safari do not support document.createEvent("touchevent"), we should just delete it.
DOM spec: https://dom.spec.whatwg.org/#dom-document-createevent.