Consolidate label conversion tests + add timeLog #11401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Jun 8, 2018
|
|
||
| // toString error re-throwing console test strings | ||
| const toStringRethrowAssertionEnding = 'must re-throw any exceptions thrown by label.toString() conversion'; | ||
| const toStringRethrowTestNameEnding = 'throws exceptions generated by erroneous label.toString() conversion'; |
There was a problem hiding this comment.
Not sure why these test strings are factored out instead of inlined; it makes things a big harder to read.
There was a problem hiding this comment.
Ah I think before using the for loop I had factored them out to avoid duplication, but that's not an issue at all now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes some
TODOs for the existing console label conversion tests and also adds necessary label conversion tests forconsole.timeLog. (This does not satisfy all oftimeLog's necessary requests, just the tests of this kind). I've also manually tested that this works etc.