Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chrome ios wptrunner result in FYI #3754

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

sj0602
Copy link
Contributor

@sj0602 sj0602 commented Mar 20, 2024

Add the Chrome iOS product since the work to upload test runs is done.

@past past self-requested a review March 20, 2024 00:26
Copy link
Member

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean revert of #3569, but it still suffers from the broken icon. Can you fix this?

@WeizhongX
Copy link
Collaborator

481e1b9 is a similar one that add icon for webview.

@sj0602
Copy link
Contributor Author

sj0602 commented Mar 20, 2024

This is a clean revert of #3569, but it still suffers from the broken icon. Can you fix this?

Oh yes, I will create another PR to fix that issue now.
Thanks.

@sj0602
Copy link
Contributor Author

sj0602 commented Mar 20, 2024

#3755 this should fix the logo issue.
We already have the ios platform logo, just make sure chrome_ios use the same chrome logo as chrome_android.

@past
Copy link
Member

past commented Mar 20, 2024

Can you add the icon change as a commit in this PR? This way the change is self-contained, which helps with maintenability and reverts. I will merge this afterwards.

@sj0602
Copy link
Contributor Author

sj0602 commented Mar 20, 2024

Can you add the icon change as a commit in this PR? This way the change is self-contained, which helps with maintenability and reverts. I will merge this afterwards.

Done, updated.
Could you help me to merge this?
Many thanks.

@past
Copy link
Member

past commented Mar 20, 2024

Oh, heh, it looks like you did this as I was typing my comment. Thanks!

@past past merged commit 032467b into web-platform-tests:main Mar 20, 2024
12 checks passed
@sj0602
Copy link
Contributor Author

sj0602 commented Mar 20, 2024

Oh, heh, it looks like you did this as I was typing my comment. Thanks!

Yep, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants