Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unfinished chrome_ios product #3569

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Remove the unfinished chrome_ios product #3569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daffae2
Remove unused variable that causes hterm error
past Oct 27, 2023
add1b14
Revert "Add chrome_ios as a browser name (#3087)"
past Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/browsers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var defaultBrowsers = []string{

// An extra list of known browsers.
var extraBrowsers = []string{
"android_webview", "chrome_android", "chrome_ios", "chromium", "deno", "epiphany", "firefox_android", "flow", "node.js", "servo", "uc", "wktr", "webkitgtk",
"android_webview", "chrome_android", "chromium", "deno", "epiphany", "firefox_android", "flow", "node.js", "servo", "uc", "wktr", "webkitgtk",
}

var allBrowsers mapset.Set
Expand Down
3 changes: 1 addition & 2 deletions shared/browsers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build small
// +build small

// Copyright 2017 The WPT Dashboard Project. All rights reserved.
Expand All @@ -20,7 +21,6 @@ func TestGetDefaultBrowserNames(t *testing.T) {
for _, n := range names {
assert.NotEqual(t, "android_webview", n)
assert.NotEqual(t, "chrome_android", n)
assert.NotEqual(t, "chrome_ios", n)
assert.NotEqual(t, "chromium", n)
assert.NotEqual(t, "deno", n)
assert.NotEqual(t, "epiphany", n)
Expand All @@ -45,7 +45,6 @@ func TestIsBrowserName(t *testing.T) {
assert.True(t, IsBrowserName("node.js"))
assert.True(t, IsBrowserName("safari"))
assert.True(t, IsBrowserName("chrome_android"))
assert.True(t, IsBrowserName("chrome_ios"))
assert.True(t, IsBrowserName("android_webview"))
assert.True(t, IsBrowserName("epiphany"))
assert.True(t, IsBrowserName("servo"))
Expand Down
2 changes: 0 additions & 2 deletions shared/product_spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ func (p ProductSpec) DisplayName() string {
return "Chromium"
case "chrome_android":
return "ChromeAndroid"
case "chrome_ios":
return "ChromeIOS"
case "android_webview":
return "WebView"
case "deno":
Expand Down
1 change: 0 additions & 1 deletion util/commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/bash

DOCKER_DIR=$(dirname $0)
DOCKER_IMAGE=${DOCKER_IMAGE:-"webplatformtests/wpt.fyi:latest"}
DOCKER_INSTANCE=${DOCKER_INSTANCE:-"wptd-dev-instance"}
WPTD_HOST_WEB_PORT=${WPTD_HOST_WEB_PORT:-"8080"}
Expand Down
3 changes: 1 addition & 2 deletions webapp/components/product-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const DisplayNames = (() => {
['safari', 'safari-experimental'].forEach(n => m.set(n, 'Safari'));
m.set('android_webview', 'WebView');
m.set('chrome_android', 'ChromeAndroid');
m.set('chrome_ios', 'ChromeIOS');
m.set('chromium', 'Chromium');
m.set('deno', 'Deno');
m.set('firefox_android', 'Firefox Android');
Expand Down Expand Up @@ -47,7 +46,7 @@ const versionPatterns = Object.freeze({
});

// The set of all browsers known to the wpt.fyi UI.
const AllBrowserNames = Object.freeze(['android_webview', 'chrome_android', 'chrome_ios', 'chrome',
const AllBrowserNames = Object.freeze(['android_webview', 'chrome_android', 'chrome',
'chromium', 'deno', 'edge', 'firefox_android', 'firefox', 'flow', 'node.js', 'safari', 'servo', 'webkitgtk', 'wktr']);

// The list of default browsers used in cases where the user has not otherwise
Expand Down