Dynamically add stable or experimental labels to Interop Dashboard URLs

[DanielRyanSmith]

Fixes #3286

This change adds the stable or experimental labels to test results links on the Interop dashboard based on the view that the user is viewing. Previously, the "experimental" label was used for all links, even when viewing stable data.

[KyleJu]

I would assume that ? delimiter is always present in the testURL, e.g. /results/ vs /results/? /results/&label=stable would fail here

[DanielRyanSmith]

Yes, these are always wpt.fyi paths to test results pages with an interop label, so the query string should always already be present

[foolip]

Another way would be:

const url = new URL(testsURL);
url.searchParams.set('label', stable ? 'stable' : 'experimental');
return url.toString();

This works regardless of what the query string is initially.

[DanielRyanSmith]

After trying this, I think using the URL object might not work in our specific case because we allow for multiples of the same query string parameter (e.g. multiple "label" params). Using the set method might overwrite a &label=master search param.

[jcscottiii]

I looked at the URLSearchParams API.
Yeah, you're right, I wish there was a setAll method.

Here's a fiddle with it working but it adds a lot of lines of code using the existing APIs for URLSearchParams. (Probably can be optimized)

[DanielRyanSmith]

Thanks for the example @jcscottiii 🙂 I agree that it would be nice to have another method that allows for multiples of the same search param.
Would you suggest updating the implementation to match? Or do you think the current implementation is fine?

[jcscottiii]

I would update the implementation to match. I like @foolip's suggestion because search parameter modification shouldn't be something we deal with manually if we can avoid it.
I did some searching to make sure we weren't the only ones looking for this same solution.

You should put a TODO note that it could be simplified and add these three links:

• URLSearchParams append/set: variadic values argument? whatwg/url#762
• URLSearchParams.appendAll(iterable) whatwg/url#461
• URLSearchParams delete all vs delete one whatwg/url#335

Any of those would help simplify the code a little bit.

[KyleJu]

Thanks for addressing the comments!