-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing docs: explain compat_features
versus tags
#1667
Conversation
Co-authored-by: James Stuckey Weber <[email protected]>
This removes the explanation of why this is optional, which should stay in some form:
Also, this does not convey the intricacies of your answer in #1633:
But maybe that's a lot for the table entry? Perhaps there's a better home for it, since this bit helped me understand the flow of the system as a whole better. |
Yeah, I think it's too much for the table. Really, we need a standalone fields reference. Maybe the That said, I tried to bring my comment into the section that follows, about dist files. This effect now gets at least three mentions:
What do y'all think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1633