Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ›More fixes + additional features #72

Merged
merged 6 commits into from
Feb 1, 2025
Merged

๐Ÿ›More fixes + additional features #72

merged 6 commits into from
Feb 1, 2025

Conversation

GlassyFoozle
Copy link
Collaborator

@GlassyFoozle GlassyFoozle commented Feb 1, 2025

๐Ÿ“Œ Pull Request Template

๐Ÿ“‹ ์ž‘์—… ๋‚ด์šฉ

๋ณ€๊ฒฝ๋œ ๋‚ด์šฉ

  • ๊ฒ€์ƒ‰ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋น„๋งค๋„ˆ ํ‰๊ฐ€ + ์กฐํšŒ ์ถ”๊ฐ€. ๋‚จ ํ”„๋กœํ•„์—์„œ ๋งค๋„ˆ ํ‰๊ฐ€ํ•˜๋Š” ํŽ˜์ด์ง€๋Š” TempPage๋กœ ์ด๋™๋˜๋„๋ก ํ•จ
  • ๊ตฌ๋งค์ž ์ฑ„ํŒ…์ฐฝ์—์„œ ๊ฑฐ๋ž˜์™„๋ฃŒ๋œ ์ƒํ’ˆ์— ๋Œ€ํ•ด ํ›„๊ธฐ ์ž‘์„ฑ ๊ฐ€๋Šฅ
  • ๋‚ด ํŒ๋งค๋‚ด์—ญ์—์„œ ์ƒํƒœ ๋ณ€๊ฒฝ์‹œ ๋กœ๋”ฉ ๊ฐœ์„ , ๊ฑฐ๋ž˜์™„๋ฃŒ๋กœ ์ƒํƒœ ๋ณ€๊ฒฝ์‹œ SendReviewPage๋กœ ์—ฐ๊ฒฐ + ๊ตฌ๋งค์ž ์„ ํƒ ํ™”๋ฉด ํ‘œ์‹œ

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ๋นŒ๋“œ๋จ
  • Linter
  • ๋ชจ๋“  ํ…Œ์ŠคํŠธ ํ†ต๊ณผ
  • kanban update

๐Ÿ’ฌ ๋ฆฌ๋ทฐ ์š”๊ตฌ์‚ฌํ•ญ


โš ๏ธ ์ฃผ์˜ ์‚ฌํ•ญ

  • <๋จธ์ง€ ์ „ ๋ฆฌ๋ทฐ ์‹œ ํ™•์ธํ•ด์•ผ ํ•  ํŠน์ด์‚ฌํ•ญ์„ ์ž‘์„ฑํ•˜์„ธ์š”>
    • ์˜ˆ) ํŠน์ • ๊ธฐ๋Šฅ์ด ๋กœ์ปฌ์—์„œ๋งŒ ๋™์ž‘ํ•˜๋‹ˆ ํ™˜๊ฒฝ ์„ค์ • ํ™•์ธ ํ•„์š”
    • ์˜ˆ) DB Schema ๋ณ€๊ฒฝ์œผ๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ ํ•„์ˆ˜

๐Ÿ“Ž ์ฐธ๊ณ  ์ž๋ฃŒ

@GlassyFoozle GlassyFoozle merged commit f55e943 into main Feb 1, 2025
1 check passed
@GlassyFoozle GlassyFoozle deleted the feat/fixes branch February 1, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant