Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote track channelCount #3025

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add remote track channelCount #3025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
308a590
Add remote track channelCount
henbos Nov 26, 2024
9cde211
Merge branch 'main' into 241126_channelCount
henbos Nov 28, 2024
3579baa
Update description
henbos Nov 28, 2024
5d27f27
data-tests
henbos Nov 28, 2024
c4a49af
Merge branch 'main' into 241126_channelCount
dontcallmedom Jan 17, 2025
7475848
Fix amendments.json
dontcallmedom Jan 17, 2025
7eff351
Fix amendments.json
dontcallmedom Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,5 +1242,21 @@
"web-platform-tests/wpt#48361"
]
}
],
"remote-track-settings-channel-count": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"remote-track-settings-channel-count": [
"def-constraint-channelCount": [

{
"description": "Use Performance.timeOrigin + Performance.now() for stats timestamps",
henbos marked this conversation as resolved.
Show resolved Hide resolved
"type": "addition",
"status": "candidate",
"difftype": "append",
"id": 51,
"pr": 3025,
"tests": [
"webrtc/RTCRtpEncodingParameters-codec-opus-stereo.https.html"
],
"testUpdates": [
"web-platform-tests/wpt#48599"
]
}
]
}
1 change: 1 addition & 0 deletions base-rec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15948,6 +15948,7 @@ <h4 id="x9-3-1-mediatracksupportedconstraints-mediatrackcapabilities-mediatrackc
double rounded to the tenth decimal place.
</td>
</tr>
<div id="remote-track-settings-channel-count"><!-- ammendment --></div>
</tbody>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div id="remote-track-settings-channel-count"><!-- ammendment --></div>

not needed since it's an append amendment

</table>
<p class="no-test-needed">
Expand Down
15 changes: 15 additions & 0 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16583,6 +16583,21 @@ <h4>
double rounded to the tenth decimal place.
</td>
</tr>
<div id="remote-track-settings-channel-count">
<tr id="def-constraint-channelCount">
Comment on lines +16680 to +16681
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div id="remote-track-settings-channel-count">
<tr id="def-constraint-channelCount">
<tr id="def-constraint-channelCount">

<th data-tests="">
henbos marked this conversation as resolved.
Show resolved Hide resolved
channelCount
</th>
<td>
{{ConstrainULong}}
</td>
<td>
As a setting, this is the number of channels of the latest
audio frame received, reflecting the number of
{{RTCRtpCodec/channels}} that the decoder outputted.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from Youenn: make this more clear that you MUST do what the decoder is capable of

</td>
</tr>
</div>
Copy link
Member

@dontcallmedom dontcallmedom Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div>

</tbody>
</table>
<p class="no-test-needed">
Expand Down