Fix missing steps and fields in "report an error" in log module. #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing steps common to the regular console events: - Creating the `timestamp` field. - Creating `body` from `entry`. Also, the `stack` value was created in its own step, but was not listed in the list of fields creating the specific `log.JavascriptLogEntry` production.
|
Just connected my W3C account to my GitHub one, but validation is still failing. Does it take some time to work? Or is this small enough to be marked as non-substantive? |
OrKoN
approved these changes
Dec 20, 2024
I assume you filled out the form at https://www.w3.org/groups/wg/browser-tools-testing/join/? |
Just did it, and the IPR check is now passing. :) |
github-actions bot
added a commit
that referenced
this pull request
Jan 8, 2025
SHA: 0a9eed7 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing steps common to the regular console steps, also in the
logmodule:timestampfield.bodyfromentry.Also, the
stackvalue was created in its own step, but was not listed in the list of fields creating the specificlog.JavascriptLogEntryproduction.Preview | Diff